ni / ni/nimi-python

Get rid of disabled example for nidcpower - `nidcpower_advanced_sequence`

Open
#1,454 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

examples nidcpower task
Dominant language
Python
Stars
128
Forks
110
Avg merge
5d 14h
Merged PRs (30d)
10

Description

Description of issue

In nidcpower 1.0, Advanced Sequencing was not part of the public API (https://github.com/ni/nimi-python/issues/504). It could still be done via private API. Hence, the example for it was put in disabled_examples folder.

When Advanced Sequencing was added in public API (https://github.com/ni/nimi-python/pull/1289), a new example was created for it. But the existing disabled example was left untouched; I believe due to oversight. We should get rid of the disabled example.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the disabled_examples entry for nidcpower_advanced_sequence with src/nidcpower/examples/nidcpower_advanced_sequence.py. Remove the obsolete disabled example while retaining the public API example, then run the relevant example or repository checks to confirm nothing still references the disabled copy.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.