ni / ni/nimi-python

Code generator doesn't handle complicated 'ivi-dance'

Open
#1,114 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

codegen
Dominant language
Python
Stars
128
Forks
110
Avg merge
5d 14h
Merged PRs (30d)
10

Description

Description of issue

nidigital fetch_capture_waveform_u32() uses 'ivi-dance-with-a-twist' for a parameter that actually needs two values that are then multiplied together. The code generator does not handle this.

This means the 'value_twist' should look like 'actualNumWaveforms*ActualSamplesPerWaveform' but we can't actually do this. This function is currently hand coded by modifying the generated code to work. See #1112

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the code generator's handling of value_twist and the hand-coded nidigital fetch_capture_waveform_u32() output described in this issue; compare the context in #1112. Done means the generator can represent and emit the two-value multiplication without manual changes to generated code.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.