Improve niscope system test to look at the waveforms

Open
#1,075 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
testing

Research direction

Start by locating the niscope system tests and the waveform-reordering path; inspect how retrieved waveforms are currently handled. Add assertions that verify the reordered waveform data, then run the relevant niscope system-test suite.

Written by the indexing model from the issue text.

Description

niscope priority-medium test

Description of issue

System tests don’t look at the retrieved waveforms. Since we do a bunch of reordering that we could mess up, we should improve the tests to actually look at the reordered data.

Dominant language
Python
Stars
128
Forks
110
Avg merge
5d 14h
Merged PRs (30d)
10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ni/nimi-python

All issues in ni/nimi-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.