Icons: Uptake aspect-ratio (CSS), add docs on customizing size
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 39
- Forks
- 14
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 13
Description
📌 User Story
From https://github.com/ni/nimble/pull/988#discussion_r1084187495 :
Our icons in Storybook currently don't have docs on customizing their size. We should consider adding docs for that, as well as uptaking CSS aspect-ratio (e.g. aspect-ratio: 1 / 1) like the spinner does, so that users only need to change one property (height). Icons would still keep their current default size via the icon-size token.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the icon stories and existing Storybook documentation, then compare the spinner’s CSS sizing behavior. Identify how the icon-size token sets the default and document how users can customize icon size; done means the docs explain changing height and icons support the requested aspect-ratio behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, storybook, typescript
- Domain
- design, documentation, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100