Wafer map is not theme aware
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 39
- Forks
- 14
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 13
Description
As part of making the component theme aware we should add tokens as described below.
In #835 we added some rendering code that uses hardcoded color constants. We should add these to nimble-tokens instead.
The colors are located here: https://github.com/ni/nimble/pull/835/files/1a3cb18be91dadc985f0e63f46cba83fe7f5ce7a#diff-f7818e503a099268b6e600871df415d39a36dc6e3d2f52351bc37ecd01d4dfc9
This was briefly tracked by #781 but we decided to create its own issue instead
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the rendering changes and hardcoded color constants linked from pull request #835, then review the nimble-tokens conventions. Add tokens for the wafer map colors and update the component to use them so its rendering responds to the active theme. Done means the hardcoded colors are replaced and both themes render correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- design, frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100