ni / ni/nimble

Adopt visual design for wafer map

Open
#910 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
39
Forks
14
Avg merge
1d 16h
Merged PRs (30d)
13

Description

😯 Problem to Solve

@RickA-NI (NI visual designer) produced some visual designs for wafer maps for a previous project. We should consider adopting them for the Nimble wafer map component.

💁 Proposed Solution

The designs are available in this XD document.

📋 Tasks

  • provide the color palettes listed on page 54 (copied below). We could still allow users to provide their own palette but provide these two palettes as constants that they could pass to that input instead of building their own list. The one on the left would be given a name that implies it's default (it is more accessible to people with red-green color blindness). The one on the right could be another option (it is more traditional green=good, red=bad). These colors were only designed for a light theme so we eventually will want other palettes for dark theme, so they should have names that reflect this.
  • the design doesn't specify a border or notch color, but Rick suggested using Black91 at 60% opacity. We would use the same color for all themes to start with.
  • consider providing a rendering mode to hide the notch. The product that this design was produced for didn't require a notch/border. While that product isn't being worked on, others in the future may have the same requirement.
  • ensure spacing / rendering of the grid between dies matches the design spec (see image below) Rick says the percentage-based approach which is already in use is good
  • (probably out of scope for now, but worth discussing) discuss decimation / aggregation strategy when number of dies exceeds the number of pixels available to render them This can be deferred for now since initial use cases will have smaller amounts of data / larger amounts of space, not used in a gallery mode.

image

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked Adobe XD document and the existing Nimble wafer map component. Compare the component with the specified palettes, border or notch treatment, and optional notch visibility. Done means the agreed visual design is implemented, including palette constants and rendering behavior, with any remaining theme decisions resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
design, frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.