ni / ni/nimble

Remove *-partials tokens

Open
#370 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tech debt
Dominant language
TypeScript
Stars
39
Forks
14
Avg merge
1d 16h
Merged PRs (30d)
13

Description

🧹 Tech Debt

We currently have several tokens in the form - [color token]RgbPartial – which are used with rgba() to set color transparency in component or application stylesheets.

@rajsite rajsite 7 days ago
I feel like we need to not be exposing these partial colors anymore. Other teams can't consume these reliably. Seems like we need tokens to represent the states, ie fillColorSelectedDisabled, instead of using hidden opacities?

Need to add appropriate theme aware tokens for each use of the partial tokens, and replace partial tokens in each component.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inventorying every use of the *RgbPartial tokens across the component and application stylesheets, then identify the corresponding state-specific, theme-aware tokens needed for each use. Replace all partial-token references and remove the partial tokens; done means no *RgbPartial tokens remain and each former use has an appropriate state token.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
design, frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.