ni / ni/nimble

Create 'selected-change' event API for Angular tree view directive

Open
#315 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
39
Forks
14
Avg merge
1d 16h
Merged PRs (30d)
13

Description

📌 User Story

Through discussion with @Milan Raj 🐣 and @Brian Henry we've decided that we'd like to design a different API for the 'selected-change' event for the Angular tree view directive than what was originally proposed, when the event args contained the instance of the nimble tree item component that was selected. Instead, we believe we'd like an API more similar to that of the Angular material select component, where a value can be supplied to each tree item, and that value is what is passed along in the event args of the 'selected-change' event.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Angular tree view directive and trace the existing selected-change event API. Compare the requested value-based event arguments with the Angular Material select pattern described in the issue. Done means each tree item can receive a value and selected-change emits that value rather than the selected tree item component.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.