ni / ni/nimble

nimble-tab alert support

Open
#306 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
39
Forks
14
Avg merge
1d 16h
Merged PRs (30d)
13

Description

😯 Problem to Solve

Nimble tabs should support displaying a visual "alert" indication. This is needed by SL to indicate active/inactive alarms.

💁 Proposed Solution

image

Here are some more insights about implementation details from a meeting chat.

[Yesterday 17:38] Brandon O'Keefe

Just a heads up that the Nimble Components spec includes the placement and size of that red dot. In the development spec the state is tagged as Alert_'' ''

Screen Shot 2021-09-23 at 10.34.00 AM.png

Screen Shot 2021-09-23 at 10.37.47 AM.png

[Yesterday 17:44] Lukas LK. Kall

I didn't noticed that while implementing the tabs. We might want to add another property to the element so it's easier to enable the alert. Or even set the color of it 🤔

[Yesterday 17:45] Joshua Prewitt

we will need to set the color since we use it to indicate when there is an active alarm vs inactive alarm that just needs to be acknowledged

[Yesterday 17:46] Milan Raj

We can give it a color as defined by the design system and expose it as a CSS Part where the application consumer can then style however they need 👍

[Yesterday 17:46] Milan Raj

(hopefully with tokens from the design system to represent those different color states)

[Yesterday 17:49] Brandon O'Keefe

Joshua Prewitt
we will need to set the color since we use it to indicate when there is an active alarm vs inactive alarm that just needs to be acknowledged

Also, it will be important to have set the color since the specific red value is different between light and dark modes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Nimble tabs component and reviewing how its existing states and styling are exposed. Confirm the alert placement, size, configurable color states, and CSS Part expectations against the Nimble Components and development specifications. Done means tabs can show the required alert indication with distinct colors in light and dark modes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
design, frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.