Built-in label for select and combobox
Open
@fredvisser is already working on this.
Since Oct 14, 2024.
enhancement
- Dominant language
- TypeScript
- Stars
- 39
- Forks
- 14
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 13
Description
🙋 Feature Request
😯 Problem to Solve
(Copied from AzDO feature)
Most Nimble controls offer built in labels but select and combobox don't, meaning clients have had to create and style labels manually.
This will also resolve some accessibility bugs:
https://github.com/ni/nimble/issues/94
https://github.com/ni/nimble/issues/280
💁 Proposed Solution
We should update their templates to include labels, document the feature (hopefully including guidance about when to use labels and when not), and coordinate changing client apps to use the feature.
📋 Tasks
- HLD
- Implementation in nimble-components
- Determine best way to document feature / provide usage guidance (work with @fredvisser on this)
- Related questions from Jesse on PRs:
- Should it always be provided? Only provided if the purpose of the control isn't obvious from its placeholder / default value? Do we need a way to provide it for a screen reader but not show it visibly?
- Label vs placeholder vs neither
- Team discussion 8/16: General guidance will be a label should always be provided, and placeholder shouldn't be used instead of the label. Still needs to be documented somewhere though.
- Related questions from Jesse on PRs:
- Publicize feature: SLE demo meeting in SLE demos and/or UI Working Group
- Publicize feature: UI Working Group
- @jattasNI will add something on UIWG agenda about it
- Come up with list of systemlink-lib-angular usages that need to be updated
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.