Icon intended for close buttons should not have mathematical name "times"
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 39
- Forks
- 14
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 13
Description
🐛 Bug Report
The Nimble icon designated with the "close" metaphor is nimble-icon-times, while the more generically-named icon, nimble-icon-xmark is not intended for that purpose. This is counter-intuitive.
💁 Possible Solution
Maybe nimble-icon-xmark-small as new name.
See discussion in PR thread.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the icon naming discussion in PR 2130 and locating the definitions and usages of nimble-icon-times and nimble-icon-xmark. Confirm the intended replacement name, then update the close-button icon references consistently and verify that the old and new names are no longer confused.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- design
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100