ni / ni/nimble

Combobox `inline` mode has unexpected dropdown keyboard navigation

Open
#1,985 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
39
Forks
14
Avg merge
1d 16h
Merged PRs (30d)
13

Description

🐛 Bug Report

When navigating the dropdown of a Combobox that has its autocomplete set to inline, then if the Combobox has its value set to something other than '', it will only navigate between items in the dropdown that match from the beginning of the current value. For example, if the value is "Sue", and there are "Sue", "Mary", and "Sue Ann" in the dropdown, a user can only navigate between "Sue" and "Sue Ann" in the dropdown, despite "Mary" being visible.

💻 Repro or Code Sample

This is an issue in the FAST Combobox implementation.

🤔 Expected Behavior

All dropdown options should be able to be selected via keyboard navigation.

😯 Current Behavior

As described, if a value has been set, keyboard navigation will skip over all options that don't match the current value text from the beginning.

💁 Possible Solution

The problem almost certainly has to do with the Combobox relying on its filteredOptions which are not being reset to the entire available options, when the autocomplete isn't set to a filter mode (either list or both).

🔦 Context

🌍 Your Environment

  • OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
  • Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
  • Version [e.g. 1.8.0]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the FAST Combobox implementation linked in the issue and reproduce the problem using inline autocomplete with a non-empty value and options such as Sue, Mary, and Sue Ann. Inspect how filteredOptions are used during keyboard navigation. Done means every visible dropdown option can be selected with the keyboard, including options that do not match the current value from the beginning.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.