TurboSnap still used even when "external" file changes
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 39
- Forks
- 14
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 13
Description
🧹 Tech Debt
In main.yml we specify a few paths in externals, which could affect all/any snapshots, so TurboSnap should be disabled.
In my experimentation, changing a color token value in packages/nimble-tokens/source/styledictionary/properties/colors.json did not result in TurboSnap being disabled, even though it matches one of our externals patterns: ./packages/nimble-tokens/source/styledictionary/properties/**.
The first step for this issue is to double check that our configuration is correct and search for / file an issue to Chromatic.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in .github/workflows/main.yml around line 90 and verify how the externals patterns are configured. Reproduce the change to packages/nimble-tokens/source/styledictionary/properties/colors.json, then determine whether the configuration or Chromatic is responsible; done means the configuration is verified and any needed Chromatic issue is filed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100