Combobox should stop altering `hidden` state of options
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 39
- Forks
- 14
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 13
Description
🧹 Tech Debt
There have been issues surrounding the filtering process of the Combobox (and the Select) updating the hidden state of options. While the Select is addressing this problem, the Combobox is still in need of the same solution.
The Combobox should adjust its implementation to no longer manipulate the hidden attribute directly while filtering, and instead leverage the now available visuallyHidden attribute of the ListOption.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Combobox filtering implementation and compare it with the Select solution referenced in pull request 1842. Inspect how ListOption exposes visuallyHidden, then update the Combobox filtering behavior so it no longer directly changes hidden; done means filtering uses visuallyHidden consistently and existing component tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100