ni / ni/nidaqmx-python

Test filtering in tox.ini is imprecise

Open
#848 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tech debt
Dominant language
Python
Stars
592
Forks
199
Avg merge
1d 16h
Merged PRs (30d)
10

Description

Tech Debt

-k "not grpc" filters out tests that contain grpc in their name or use the grpc_init_kwargs fixture, but unfortunately it also seems to filter out tests that have a grpc_skip marker.

-k "library" only runs tests that contain library in their name or use the library_init_kwargs fixture, and unfortunately it also filters out tests that are not specific to library or grpc, such as feature toggle tests.

AB#3354823

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tox.ini and inspect the test commands using the -k "not grpc" and -k "library" filters. Review tests using the grpc_skip marker, grpc_init_kwargs, library_init_kwargs, and feature toggles; done means the filters exclude only their intended test groups and retain unrelated tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, testing-qa
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.