ni / ni/measurement-plugin-python

Clean up the unused `build_in_import_modules` dictionary in ni-measurement-plugin-client-generator

Open Beginner friendly
#979 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tech debt
Dominant language
Python
Stars
21
Forks
20
Avg merge
1d 16h
Merged PRs (30d)
3

Description

Tech Debt

As discussed in this comment.

In #871, we hard-coded the 'import pathlib', but continued iterating through the built_in_import_modules dictionary, which only contained the 'import pathlib' string literal until it was removed in #900. The use of built_in_import_modules was eliminated in #931. As a result, the built_in_import_modules dictionary and the _PATH_IMPORT variable are no longer used or required and should be removed.

AB#2903265

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py and inspect the unused built_in_import_modules dictionary and _PATH_IMPORT variable. Remove both, then run the generator's existing checks or tests to confirm generated client behavior is unchanged and no references remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.