nginx / nginx/ngx-rust

Subrequest API requires data support and API updates.

Open
#34 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
915
Forks
96
Avg merge
5d 22h
Merged PRs (30d)
6

Description

Is your feature request related to a problem? Please describe.
During the development of a retry module gaps in the current subrequest API support were identified.

  • need getters for request status and subrequest depth
  • need to increment cycle count
  • the flags argument is not supported
  • the args argument is not supported
  • need to pass custom data to subrequest
  • do not automatically destroy subrequest body (allow caller to handle body lifetime)
  • suggested: provide a basic subrequest example module

Describe the solution you'd like
Add additional API support. This work has mostly been complete here but needs to be separated from the Event timer API work and linting updates. See the src/http/flags.rs and src/http/request.rs files for salient changes.

Additional context
Since this work is mostly completed by @avahahn and @f5yacobucci please see them for unclear details. This issue is a placeholder tracking issue to break apart an existing PR into its component features.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/http/flags.rs and src/http/request.rs, then compare the existing ava-subreq-depth branch. Clarify the intended component boundaries with @avahahn or @f5yacobucci. Done means the subrequest API updates are separated from the Event timer and linting work, with the listed support gaps addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.