nginx / nginx/docker-nginx

Changing the order of checks in entrypoint 10

Open
#939 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
3.5k
Forks
1.8k
Avg merge
42m
Merged PRs (30d)
2

Description

Wouldn't flipping these lines make more sense?
If ipv6 is enabled then we wouldn't need to check if the file is writable. The exit message will be more informative, instead of sending the user in a wild hunt.

https://github.com/nginxinc/docker-nginx/blob/6a4c0cb4ac7e53bbbe473df71b61a5bf9f95252f/entrypoint/10-listen-on-ipv6-by-default.sh#L26-L30

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at entrypoint/10-listen-on-ipv6-by-default.sh, specifically lines 26-30 linked in the issue, and review the current order of the checks. Done means the checks produce the more informative exit message described when IPv6 is enabled, without introducing a regression in the entrypoint behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, shell
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.