nginx / nginx/docker-nginx

Entrypoint:envsubst skip if already done

Open
#447 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
3.5k
Forks
1.8k
Avg merge
42m
Merged PRs (30d)
2

Description

Envsubst happens every time you start the container. Wouldn't it be better if it passed after finding file already touched by it?

This overwrites any manual changes made to the envsubst output conf file.

Example use case:

  1. create generic template
  2. run envsubst
  3. add ssl
  4. don't lose ssl when container restarts

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the container entrypoint and inspect the envsubst path described in the issue. Verify the behavior by substituting a template, making a manual SSL-related change to the output configuration, and restarting the container; done means the existing output is preserved instead of being overwritten.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, shell
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.