nginx-proxy / nginx-proxy/docker-gen
Add check option
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 4.6k
- Forks
- 609
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 4
Description
It would be good to be able to run a check command before running notify command to ensure that the generated file is valid. For example, being able to run nginx -t before runing nginx reload would help prevent errors such as https://github.com/jwilder/nginx-proxy/issues/107
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating the code that generates files and runs the notify command, then trace how command failures are handled. Done means a configurable check command, such as nginx -t, runs before notification and prevents notification when validation fails.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, go, nginx
- Domain
- devops, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100