ng-bootstrap / ng-bootstrap/ng-bootstrap

Focus is going out of the modal, if it is having hidden button as the last interactive element.

Open
#4,630 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component: modal type: bug
Dominant language
TypeScript
Stars
8.2k
Forks
1.6k
PR merge metrics
No merged PRs in 30d

Description

Bug description:
While traversing through the elements, focus is going out of the modal if last interactive button is hidden on modal.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 15.2

ng-bootstrap: 14

Bootstrap: 6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in an Angular modal whose last interactive button is hidden, then trace the modal's focus-management entry point. Verify keyboard traversal when the final visible control is reached; done means focus remains inside the modal rather than moving outside it.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, bootstrap, typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.