nfroidure / nfroidure/knifecycle
Consider allowing `$overrides` service autoload
Open
@nfroidure is already working on this.
Since Nov 18, 2024.
enhancement
question
- Dominant language
- TypeScript
- Stars
- 34
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Currently, the service is a constant (and is forced to be a constant) https://github.com/nfroidure/knifecycle/blob/main/src/index.ts#L283
The reason for it is that loading a service could lead to different results overtime which is not a good thing.
That said, we could allow to change the $overrides mapping (and autoload it) by checking that the mapping were not used yet and refuse to change it by another mapping that don't fit the previously mapped service names.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.