nfrechette / nfrechette/rtm

Strip vector_mix unit tests when not explicitly enabled

Open
#244 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
799
Forks
51
PR merge metrics
No merged PRs in 30d

Description

We current add a define that strips the code but the cpp files still compile and include the header which takes a lot of time given the large number of files. They are also quite slow to run individually with emscripten even though they do nothing. SonarCloud must also scan them, which is slow as well.

Keeping them when they are disabled has little value. We should strip the files entirely when not enabled.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the vector_mix unit-test C++ files and the define that currently strips their code. Verify how the files are included in builds with the option disabled, including the Emscripten and SonarCloud paths. Done means disabled tests are omitted entirely while explicitly enabled tests still compile and run.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.