Update lint checks for `modules_testdata_base_path` and `pipelines_testdata_base_path`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 322
- Forks
- 255
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 5
Description
Description of feature
The parameters modules_testdata_base_path and pipelines_testdata_base_path currently need to be defined in both tests/nextflow.config and nextflow.config. To prevent duplication of parameter definitions, simplify updates, and reduce ambiguity, it would be better if parameters were only defined once. This should be done in nextflow.config only so that configs included here can access these variables, but it is currently not possible due to current linting checks, for example:
nf_test_content: 'tests/nextflow.config' does not contain pipelines_testdata_base_path
For this, it is necessary to:
- Remove
modules_testdata_base_pathandpipelines_testdata_base_pathfromtests/nextflow.config. - Remove associated linting checks for the content of
tests/nextflow.config. - Add linting checks for the content of
nextflow.configinstead.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect tests/nextflow.config and nextflow.config, then locate the lint checks that validate their parameter contents. Remove the duplicated parameters and update the checks so nextflow.config is validated instead; done when the lint checks pass with definitions only in nextflow.config.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100