nf-core / nf-core/tools

linting tests for quotes in versions command

Open
#3,975 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
322
Forks
255
Avg merge
2d 3h
Merged PRs (30d)
5

Description

Description of feature

both quotes or non quotes are working with linting, so we are already not consistent on that decision.
Given the fact that we might want to use quotes to preserve some characters, and that consistency is my hill to die on, I would rather we force this usage.

cf https://github.com/nf-core/modules/pull/9624#discussion_r2671468768
https://nfcore.slack.com/archives/C09LJTQQ3EY/p1767863589778579

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linting implementation and tests for the versions command, then read the linked pull request discussion and Slack thread for the intended quoting decision. Done means the linting tests consistently enforce the chosen quoted form, including cases where quotes preserve characters.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.