nf-core / nf-core/tools

Allow less strict job name for nf-test in ci workflows

Open
#3,950 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
322
Forks
255
Avg merge
2d 3h
Merged PRs (30d)
5

Description

Description of feature

Hi,

when one needs to run several nf-test jobs in .github/workflows/nf-test.yml under different conditions and renames the job from nf-test to something like nf-test-standard and nf-test-special, the linting will fail due to the Nextflow minimum version not being found.

Would it be an option to be less strict on the job name and add a regex pattern that matches nf-test.* rather than nf-test explicitly ?
https://github.com/nf-core/tools/blob/b478d8a498305ded64c825715a4dad0714c673cc/nf_core/pipelines/lint/actions_nf_test.py#L66

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in .github/workflows/nf-test.yml and inspect the job-name handling at nf_core/pipelines/lint/actions_nf_test.py#L66. Check how the linter identifies the nf-test job, then verify that renamed jobs such as nf-test-standard and nf-test-special are accepted while the minimum Nextflow version is still detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ci-cd, tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.