nf-core / nf-core/tools

Fail tests for module linting instead of skipping them

Open
#3,727 0 comments 0 reactions 0 assignees View on GitHub

@edmundmiller is already working on this.

Since Aug 27, 2025.

  • #3733 by @edmundmiller — open
Dominant language
Python
Stars
322
Forks
255
Avg merge
2d 3h
Merged PRs (30d)
5

Description

Tests shouldn't be skipped if the setup install fails.

Introduced in #3592

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the change introduced in #3592 and the open pull request #3733, then locate the module-linting tests and their setup-install handling. Confirm how installation failures are currently treated. Done means those failures fail the tests rather than causing them to be skipped.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.