nf-core / nf-core/tools

Allow user names with dots when creating modules

Open
#3,655 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good-first-issue
Dominant language
Python
Stars
322
Forks
255
Avg merge
2d 3h
Merged PRs (30d)
5

Description

Description of the bug

When hosting your own modules repo on let's say gitlab, the username might contain dots because they are allowed there. The modules creation for the username does not like this and errors with an error message about missing the @

Can we be less strict on the user names to account for other git providers?

Command used and terminal output

System information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the module-creation command and the username validation that rejects names containing dots. Reproduce the failure with a dotted username from a self-hosted GitLab-style repository, then verify that valid dotted names are accepted without removing the existing @ validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.