nf-core / nf-core/tools

Single qutation mark ' in a comment makes AWS release full test break

Open
#3,273 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
322
Forks
255
Avg merge
2d 3h
Merged PRs (30d)
5

Description

Description of the bug

A single quotation mark in the word "don't" in a comment on a release PR causes the AWS full test triggered upon two approvals to fail with exit code 2 before being dispatched on AWS.

This is the failed test run, and this is the link to the evil comment of @jfy133 :) I am going to edit this comment and re-run the test, hoping that this will fix the issue on this PR.

Please find a way to prevent others from blocking releases by using "don't" and similar words in comments. Thanks in advance! :)
@mashehu @mirpedrol

Command used and terminal output

No response

System information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the failed AWS full-test run and the linked release PR review comment, then trace the release workflow step that parses approval comments. Reproduce the failure with a comment containing "don't" and confirm that the workflow reaches AWS dispatch without exit code 2. Done means similar quoted comments no longer block the release test.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, github-actions
Domain
ci-cd, cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.