nf-core / nf-core/tools

nf-core lint failing for mismatching assets/sendmail_template.txt

Open
#2,704 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
322
Forks
255
Avg merge
2d 3h
Merged PRs (30d)
5

Description

Description of the bug

I am trying to merge in the template update after the latest 2.12 release into nf-core/fetchngs and nf-core lint is failing with:

╭─ [✗] 1 Pipeline Test Failed ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                                                                                                                                                                                                 │
│ files_unchanged: assets/sendmail_template.txt does not match the template                                                                                                                                                                                                                       │
│                                                                                                                                                                                                                                                                                                 │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯


╭───────────────────────╮
│ LINT RESULTS SUMMARY  │
├───────────────────────┤
│ [✔] 179 Tests Passed  │
│ [?]   9 Tests Ignored │
│ [!]   6 Test Warnings │
│ [✗]   1 Test Failed   │
╰───────────────────────╯

This file is intentionally different and I have already added the block below to .nf-core.yml as you can see here which should exclude this file from being linted but still seeing the failure:

files_unchanged:
    - assets/sendmail_template.txt

Cloning the branch on the PR above and running nf-core lint with the latest version should reproduce the issue locally too.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure by cloning the branch from PR 257 and running the latest nf-core lint. Inspect .nf-core.yml and the files_unchanged check for assets/sendmail_template.txt. Done means the intentionally modified file is excluded and the lint run no longer reports it as a failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.