nf-core / nf-core/tools

Make GHA CI MyPy smarter in descerning when it should perform type checking

Open
#2,480 1 comment 0 reactions 1 assignee View on GitHub

@kedhammar is already working on this.

Since Oct 17, 2023.

enhancement
Dominant language
Python
Stars
322
Forks
255
Avg merge
2d 3h
Merged PRs (30d)
5

Description

Description of feature

Currently static type checking is performed on all modified files, but implementing type checking is a work in progress.

Possible solutions:

  • Put headers in the files we want to typecheck / ignore
  • Keep a list of files to typecheck / ignore

We should also add MyPy and its additional type dependencies in requirements-dev.txt

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.