`nf-core modules install` fails to write module to path with custom remote
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 322
- Forks
- 255
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 5
Description
Description of the bug
When calling e.g. nf-core modules -g https://github.com/erikrikarddaniel/nf-core-modules.git -b epang-place-one-arg install epang/place the program tries to install the module in modules/nf-core/ instead of in modules/erikrikarddaniel.
This worked after @ErikDanielsson implemented it in the summer, did it break when the directory structure was changed?
Command used and terminal output
$ nf-core modules -g https://github.com/erikrikarddaniel/nf-core-modules.git -b epang-place-one-arg install epang/place
System information
nf-core tools 2.7.2
Python 3.10.8
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported nf-core modules -g ... -b ... install epang/place command and trace how the custom remote determines the destination path. The fix is done when the module is written under modules/erikrikarddaniel rather than modules/nf-core/; the payload does not name a source file or test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100