nf-core / nf-core/tools

Customized Linting mismatch with Schema linting

Open
#1,968 1 comment 0 reactions 1 assignee View on GitHub

@asp8200 is already working on this.

Since Mar 18, 2024.

bug infrastructure
Dominant language
Python
Stars
322
Forks
255
Avg merge
2d 3h
Merged PRs (30d)
5

Description

Description of the bug

I have a customized internal pipeline that uses the nf-core template but uses only portions of it (as introduced with 2.5X release of tools):

My .nf-core.yml (only the relevant parts of it):

repository_type: pipeline
lint:
  nextflow_config:
  - manifest.name
  - manifest.homePage
  - params.input

This results in linting saying config variable is ignored:

image

But nf-core lint says:

image

Which is true - it is neither in the schema nor in nextflow.config. If I remove the above linting exception, it throws a warning that the pipeline is missing --input.

Cross checking by just running nf-core schema lint . says "all fine":

image

My expectation would be that the linting warning should not even be there....

Command used and terminal output
nf-core lint / nf-core schema lint
System information

tools 2.6, linux on centos 7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.