nf-core / nf-core/tools

Favicon picker only works once on schema webb builder

Open
#1,767 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
322
Forks
255
Avg merge
2d 3h
Merged PRs (30d)
5

Description

Description of the bug

Icon picker is not working as expected as described in Slack https://nfcore.slack.com/archives/CE5LG7WMB/p1661424756960159

The icon chooser popup only appears on the firs click, afer the icon chooser window is deselected by either pressing Esc or clicking another part of the page, it will not appear again.

It might be a related issue that if e.g. the fingerprint icon is chosen and the page reloaded it gives the following error:

FontAwesome icon did not match the regex: /^fa[a-z -]+$/ ('fab fa-500px') - removing from schema.
Command used and terminal output
Run `nf-core schema build` in any nf-core pipeline.
System information

nf-core 2.5dev

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running nf-core schema build in any nf-core pipeline and reproduce the icon chooser failing after Esc or clicking elsewhere. Also reload after selecting the fingerprint icon and inspect the reported FontAwesome regex error; done means the chooser can be reopened and selected icons persist without being removed from the schema.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.