Improve --centre_name and --upload_tpa arguments usage
@mberacochea is already working on this.
Since May 12, 2026.
- Dominant language
- Nextflow
- Stars
- 18
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
Difficulty: Medium
Why this matters: --centre_name is currently required for every run of the pipeline against ENA (European Nucleotide Archive), in every mode. But according to ENA, it's only actually needed for "broker" accounts, accounts submitting data on behalf of somebody else. For a normal account, ENA works out the centre name automatically. On top of that, --centre_name is only actually used by the MAGs/bins workflow today, the metagenomic assemblies workflow ignores it completely even though the pipeline still asks every user for it. --upload_tpa has a similar scoping issue, it only matters for assemblies and MAGs/bins, not for reads.
Some terms: ENA (European Nucleotide Archive) is the public repository this pipeline submits data to, and Webin is ENA's account and authentication system needed to submit anything (free, self-service registration). A broker account is a Webin account that submits data on behalf of other organisations (for example a national data centre submitting on behalf of many research groups). TPA (Third Party Assembly) means an assembly built from data that was already public elsewhere, rather than newly generated, this is already explained well in docs/usage.md.
Skills / experience: mostly tracing where a couple of parameters are used across the codebase and cleaning that up, a good task if you want to get familiar with how parameters flow from the schema into the workflows. You'll also touch some tests, see the nf-core nf-test testing guide if nf-test is new to you.
Suggested approach:
- Read the relevant parameter tables in
docs/usage.md(mags/binsandmetagenomic_assembliessections) to see how--centre_nameand--upload_tpaare currently documented, and the "Third party assemblies (TPA)" section for background on TPA. - Find every place
--centre_nameand--upload_tpaare referenced:nextflow_schema.json,workflows/assemblysubmit.nf,workflows/genomesubmit.nf,modules/local/genome_upload/main.nf. - Confirm the assemblies workflow really doesn't use
centre_name(worth double checking, code may have changed since this was first noticed). - In
nextflow_schema.json, makecentre_nameoptional instead of required, and rename it (and the CLI flag) to--center_nameeverywhere it appears, including the README,docs/usage.md, and test configs. - Make sure the genome upload step behaves correctly when
centre_nameis left empty, it probably needs to just omit the argument rather than pass an empty string. - Double check
--upload_tpareally has no use in reads mode and keep it scoped to the modes that need it. - Update tests and docs to match.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.