nf-core / nf-core/phageannotator

COBRA options schema are listed as strings when they should be ints

Open
#123 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Nextflow
Stars
19
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Description of the bug

Trying to run COBRA and it requires three params, --cobra_assembler, --cobra_mink, --cobra_maxk. Currently the mink and maxk are expected to be strings, but they should be ints.

Related, cobra_assembler can only be "idba", "metaspades", or "megahit" per its documentation.

Command used and terminal output

Relevant files

No response

System information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No relevant files are identified in the issue. Start by locating the COBRA options schema and checking how cobra_mink, cobra_maxk, and cobra_assembler are declared, then compare those declarations with the documented parameter requirements. Done means the numeric options accept integers and the assembler option permits only the documented values, with any relevant validation passing.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.