nf-core / nf-core/modules

[Bug] meta_fb never defined in CELLRANGER_MULTI

Open
#9,798 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Nextflow
Stars
429
Forks
1.1k
Avg merge
1d 6h
Merged PRs (30d)
153

Description

Have you checked the docs?
Description of the bug

On https://github.com/nf-core/modules/blob/80db11d5d10e7319937c674afabc563bb14e3d93/modules/nf-core/cellranger/multi/main.nf#L126-L127

    fb_options_r1_length = fb_options_use && meta_fb.options.containsKey("r1-length") ? "r1-length,${meta_fb.options["r1-length"]}" : ''
    fb_options_r2_length = fb_options_use && meta_fb.options.containsKey("r2-length") ? "r2-length,${meta_fb.options["r2-length"]}" : ''

meta_fb is an undefined var in this process.
It should be replaced with fb_options.

Will make a PR tomorrow.

@tgelafr-pfzr

Command used and terminal output

Relevant files

No response

System information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read modules/nf-core/cellranger/multi/main.nf around lines 126-127, where the undefined meta_fb variable is used in the feature-barcode options expressions. Replace those references with fb_options, then verify that the module parses and the feature-barcode length options use the intended values.

Written by the indexing model from the issue text.

Assessment

Domain
bioinformatics
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.