nf-core / nf-core/modules

parabricks/fq2bam needs the fasta in the same folder as the BWAIndex

Open
#9,230 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Nextflow
Stars
429
Forks
1.1k
Avg merge
1d 6h
Merged PRs (30d)
153

Description

This leads to troubles when running on a cluster because a simple symlinking logic does not work there. However we want to move away from copying files which is not effective.

@gburnett-nvidia can you bring this up again with your team? Because we need fq2bam to be able to handle the reference differently. Maybe two command-line flags? One for fasta and one for the index?

We can update the module as soon as that works :)

See #9229 for the reverting to copying.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the current fq2bam module behavior and issue #9229 to understand the reverted copying approach. Confirm with the Parabricks team whether separate FASTA and BWA index inputs will be supported; done means the module can use that support without relying on same-folder symlinks or ineffective file copying.

Written by the indexing model from the issue text.

Assessment

Domain
bioinformatics, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.