nf-core / nf-core/modules

Container for FASTQSCREEN_FASTQSCREEN should include bismark

Open
#8,757 2 comments 0 reactions 1 assignee View on GitHub

@fbnrst is already working on this.

Since Jul 5, 2025.

bug
Dominant language
Nextflow
Stars
429
Forks
1.1k
Avg merge
1d 6h
Merged PRs (30d)
153

Description

Have you checked the docs?
Description of the bug

Fastq-screen can also be used for bisulfite sequencing analysis. For bisulfite sequencing, Bismark is a requirement, but Bismark is not present in the current container:
https://github.com/nf-core/modules/blob/fac12e7a9e255c22265ff84b09f628e03c7b96fe/modules/nf-core/fastqscreen/fastqscreen/main.nf#L6-L8

I did run into this, when I supplied the --bismark argument to FASTQSCREEN_FASTQSCREEN via ext.args.

Command used and terminal output
❯ singularity shell https://depot.galaxyproject.org/singularity/fastq-screen:0.15.3--pl5321hdfd78af_0
Singularity> bismark
bash: bismark: command not found
Relevant files

No response

System information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.