Check out if we really can remove these old tests in custom/sratoolsncbisettings
Open
Nobody has claimed this yet.
- Dominant language
- Nextflow
- Stars
- 429
- Forks
- 1.1k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 153
Description
I removed `Should fail` and `Should run with nonexisting` tests, because sratool update changed the behavior and hence the tests, rendering them no longer relevant
Originally posted by @maxulysse in https://github.com/nf-core/modules/issues/4707#issuecomment-1886757123
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the tests under custom/sratoolsncbisettings, especially “Should fail” and “Should run with nonexisting.” Compare their expectations with the current sratool update behavior and repository test conventions. Done means confirming the tests are obsolete and removing them only if the relevant test suite still passes.
Written by the indexing model from the issue text.
Assessment
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100