nf-core / nf-core/modules

gatk4/postprocessgermlinecnvcalls incorrect file type extension

Open
#12,169 1 comment 0 reactions 1 assignee View on GitHub

@kanishkanandhkumar is already working on this.

Since Jun 28, 2026.

bug
Dominant language
Nextflow
Stars
429
Forks
1.1k
Avg merge
1d 6h
Merged PRs (30d)
153

Description

Have you checked the docs?
Description of the bug

The module GATK4 postprocessgermlinecnvcalls specifies its output as:

    output:
    tuple val(meta), path("*_genotyped_intervals.vcf.gz"), emit: intervals, optional: true
    tuple val(meta), path("*_genotyped_segments.vcf.gz"), emit: segments, optional: true
    tuple val(meta), path("*_denoised.vcf.gz"), emit: denoised, optional: true

with consistent naming given for output files in the script section.

    gatk --java-options "-Xmx${avail_mem}M -XX:-UsePerfData" \\
        PostprocessGermlineCNVCalls \\
        ${calls_command} \\
        ${model_command} \\
        ${ploidy_command} \\
        ${args} \\
        --output-genotyped-intervals ${prefix}_genotyped_intervals.vcf.gz \\
        --output-genotyped-segments ${prefix}_genotyped_segments.vcf.gz \\
        --output-denoised-copy-ratios ${prefix}_denoised.vcf.gz

However, the output produced by this tool with the --output-denoised-copy-ratios flag is not in vcf format; it is a tab-separated plain text file (GATK's interval_list format), usually given a .tsv suffix. (See documentation) Additionally, it doesn't look like GATK4 supports automatic compression of this file.

I encountered this in development and don't currently have a minimal example, but I can try to produce one if really needed. Actual Nextflow run is completely clean and successful.

Command used and terminal output

Relevant files

s1_denoised.tsv.gz

System information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.