nf-core / nf-core/modules

[FEATURE] remove params from modules and subworkflows

Open
#10,248 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Nextflow
Stars
429
Forks
1.1k
Avg merge
1d 6h
Merged PRs (30d)
153

Description

Is your feature request related to a problem? Please describe

I don't mind params in the tests, but we shouldn't use them in the modules/subworkflows

modules:

subworkflows

  • DIA_PROTEOMICS_ANALYSIS (not sure about the config file)
  • FASTQ_CREATE_UMI_CONSENSUS_FGBIO
  • FASTQ_ALIGN_BWAALN (not sure about the config file)
  • QUANTIFY_PSEUDO_ALIGNMENT (not sure about the config file)
  • UTILS_NFCORE_PIPELINE (maybe we can drop this one as we are deprecating it)
  • UTILS_NFSCHEMA_PLUGIN (maybe we can drop this one as we are deprecating it)
  • UTILS_REFERENCES (let's drop this one directly as it's already deprecated)
Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the listed modules and subworkflows, including their config files and the corresponding entries under tests/. Compare them with the completed HISAT2_BUILD item and check whether the root configs are still needed. Done means the remaining listed modules and subworkflows no longer use params, with deprecated entries handled as described.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.