nf-core / nf-core/methylseq

[bug] - samplesheet schema for genome field too strict

Open Beginner friendly
#587 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Nextflow
Stars
198
Forks
181
Avg merge
6d 17h
Merged PRs (30d)
1

Description

The naming scheme for the "genome" field in the samplesheet is overly strict and forbids using paths containing a slash.
It seems sensible to allow more locations than the current directory, like absolute paths.

possible relevant line:
https://github.com/nf-core/methylseq/blob/db60bfe1f0d0409244a02c6b046301ebfd697db7/assets/schema_input.json#L34

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at assets/schema_input.json around line 34 and inspect the validation applied to the samplesheet's genome field. Adjust the schema so paths containing slashes, including absolute paths, are accepted, then run the repository's relevant schema or samplesheet validation to confirm the permitted naming forms.

Written by the indexing model from the issue text.

Assessment

Domain
bioinformatics
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.