nf-core / nf-core/mag

Consider using `collectFile` to optimise aggregating of results of bin statistics steps

Open
#532 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Nextflow
Stars
321
Forks
156
Avg merge
12h 59m
Merged PRs (30d)
5

Description

Description of feature

As described by @maxibor here: https://github.com/nf-core/mag/pull/489#issuecomment-1791336502

Where originally we were getting file name clashes of bins sent to (microbes) and skipped (eukaryotes) around DASTool. This was fixed by Maxime by adding correct prefixes with all the information, but it may make sense to use collectFile to merge the contents which would avoid such clashes. However there were some things to explore as described in the PR above.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the discussion in nf-core/mag pull request 489, especially the linked issue comment, to understand the file-clash history and the unexplored concerns around collectFile. Done means deciding whether collectFile can safely aggregate the bin-statistics results without reintroducing clashes, then documenting or implementing that decision in the workflow.

Written by the indexing model from the issue text.

Assessment

Domain
bioinformatics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.