nf-core / nf-core/funcscan

Consider passing the annotation tool output to modules input for more standardization

Open
#179 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Nextflow
Stars
119
Forks
40
Avg merge
2d 17h
Merged PRs (30d)
5

Description

Description of feature

Currently, some modules take in .fna as an input rather than taking in .faa as an input from the annotation tool assigned. This might create diffrerences in the way prediction modules particular covering teh BGC and ARG workflows, because each module runs a different annotation tool. To standardise this more, i would suggest to consider checking the 'BGC and ARG' modules to ensure, if possible, that they take already annotated '.faa' files from the annotation tool.

  • MACREL
  • GECCO
  • DEEPBGC
  • all ARG tools

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the BGC modules MACREL, GECCO, and DEEPBGC, followed by all listed ARG tools, to trace whether they consume .fna files or annotated .faa output. Compare how each module receives annotation-tool results and identify the workflow checks needed. Done means the applicable modules consistently use the assigned annotation tool's annotated .faa output.

Written by the indexing model from the issue text.

Assessment

Domain
bioinformatics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.