nf-core / nf-core/eager

DSL2: Ensure modules config consistency: all modules have an `ext.prefix` and `publishDir` attribute, and follow conventions.

Open
#1,066 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

DSL2
Dominant language
Nextflow
Stars
215
Forks
91
Avg merge
5m
Merged PRs (30d)
1

Description

Best for publishDir to be explicitly on/off, and all modules (even when not publishing) need an ext.prefix, now that we don't have meta.id anymore.
Also ensure that all module configurations follow the code conventions (attribute order etc)

Results from quick check on 26/04/2024:

  • HOST_REMOVAL : has no ext.prefix
  • SAMTOOLS_INDEX_BAM_INPUT : has neither
  • SAMTOOLS_VIEW_GENOME: no ext.prefix
  • SAMTOOLS_INDEX_DAMAGE_RESCALED: no ext.prefix
  • SAMTOOLS_INDEX_DAMAGE_FILTERED: no ext.prefix
  • SAMTOOLS_INDEX_DAMAGE_TRIMMED: no ext.prefix
  • ANGSD_DOCOUNTS: wrong attribute order
  • MTNUCRATIO : no ext.prefix
  • QUALIMAP_BAMQC_WITHBED|QUALIMAP_BAMQC_NOBED: no ext.prefix
  • SAMTOOLS_DEPTH_SEXDETERRMINE: wrong attribute order

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the DSL2 module configurations for HOST_REMOVAL, SAMTOOLS_INDEX_BAM_INPUT, SAMTOOLS_VIEW_GENOME, SAMTOOLS_INDEX_DAMAGE_RESCALED, SAMTOOLS_INDEX_DAMAGE_FILTERED, SAMTOOLS_INDEX_DAMAGE_TRIMMED, ANGSD_DOCOUNTS, MTNUCRATIO, QUALIMAP_BAMQC_WITHBED, QUALIMAP_BAMQC_NOBED, and SAMTOOLS_DEPTH_SEXDETERRMINE. Compare them with neighboring module configurations and finish when every module has ext.prefix and an explicit publishDir setting, with attributes in the established order.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.