nf-core / nf-core/crisprseq

change in BAGEL2 fold-change calculation between crisprseq v2.3.0 and v2.4.0dev

Open
#265 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Nextflow
Stars
63
Forks
39
PR merge metrics
No merged PRs in 30d

Description

Description of the bug

Hi
I have two biological replicates of two samples and this is my contrast file

reference;treatment
Day0_1,Day0_2;Untreated_1,Untreated_2

When I perform the analysis with nf-core/crisprseq (2.4.0dev), BAGEL2 calculates fold change by using reference column Day0_1 (not Day0_2). But if I do this analysis with nf-core/crisprseq (2.3.0), the fold changes are instead calculated using the mean of Day0_1 and Day0_2 as the reference.

Many thanks,

Command used and terminal output

Relevant files

No response

System information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the BAGEL2 calculation in nf-core/crisprseq 2.3.0 and 2.4.0dev with the supplied contrast file, comparing how Day0_1 and Day0_2 are used. No relevant files, command, or test are identified, so trace the pipeline's BAGEL2 input and calculation path. Done means the intended replicate handling is restored and the version difference is covered by a regression check.

Written by the indexing model from the issue text.

Assessment

Domain
bioinformatics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.