nf-core / nf-core/atacseq

CSI Implementation for Larger Genomes

Open
#414 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Nextflow
Stars
229
Forks
141
Avg merge
13h 41m
Merged PRs (30d)
1

Description

Description of feature

Hi,

I've been helping my coworker run this pipeline, but we hit an error with SAMTOOLS_INDEX, which I see isn't that uncommon. Using ext.args, we were able to resolve the error, but only a partial run followed. The last step that ran at that point was MERGED_LIBRARY_MARKDUPLICATES_PICARD, so I was able to git clone and modify the atacseq.nf at line 480 to read
.join(MERGED_LIBRARY_MARKDUPLICATES_PICARD.out.csi, by: [0])

This change allowed for more of the pipeline to run, but it still did not complete. This time, the pipeline was halted at the bam_filter_bamtools.nf subworkflow. I modified line 89 to read
bai = BAM_SORT_STATS_SAMTOOLS.out.csi.mix(SAMTOOLS_INDEX.out.csi) // channel: [ val(meta), [ bai ] ]

These changes allowed for the pipeline to complete using the csi index, and I think it'd be useful to implement these as more global changes. If I didn't have a thorough Nextflow background, I don't think we would be able to use the complete pipeline for this species, so I think making adjustments to allow for easier csi usage would benefit the community as a whole! Let me know if you'd like any additional info!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the CSI-related channel joins in atacseq.nf around line 480 and the bam_filter_bamtools.nf subworkflow around line 89. Trace how BAM indexes are passed through these steps and identify the other pipeline points that assume BAI indexes. Done means the complete pipeline runs for larger genomes using CSI indexes without manual file edits.

Written by the indexing model from the issue text.

Assessment

Domain
bioinformatics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.