nf-core / nf-core/atacseq

Set chromap to not shift reads by default

Open
#381 0 comments 0 reactions 1 assignee View on GitHub

@JoseEspinosa is already working on this.

Since Sep 27, 2024.

enhancement
Dominant language
Nextflow
Stars
229
Forks
141
Avg merge
13h 41m
Merged PRs (30d)
1

Description

Description of feature

The parameters used by chromap are the ones suggested for ATAC-seq in their documentation, see here. This includes the --Tn5-shift; thus, the shift is applied by default, unlike the rest of the aligners. As the --shift_reads parameter has been implemented now, it would make sense to not shift reads by default and only use the --Tn5-shift chromap parameter when the --shift_reads is set.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.