nf-core / nf-core/atacseq

suggestion: use samtools view --uncompressed before piping in bamtools_filter

Open
#346 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Nextflow
Stars
229
Forks
141
Avg merge
13h 41m
Merged PRs (30d)
1

Description

Description of the bug

Not really a bug, but I think, if bamtools_filter could be sighlty faster if samtools view was called with --uncompressed instead of -b.

https://github.com/nf-core/atacseq/blob/867f60dd53497a1a7eba91b5bdaff56fb29e67bb/modules/local/bamtools_filter.nf#L32

I'm too lazy to test :-P

Command used and terminal output
N/A
Relevant files

N/A

System information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open modules/local/bamtools_filter.nf at line 32 and inspect how samtools view is invoked before the pipe. Compare the proposed --uncompressed option with the current -b behavior, then verify that the filtering workflow still produces valid output and that the change improves or preserves performance.

Written by the indexing model from the issue text.

Assessment

Domain
bioinformatics
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.